Merge pull request #4 from airbus-cert/issue_3

Check m_cursor before using it (fix #3)
airbus-cert · Jul 1, 2022 · e586047 · e586047
2 parents e34667f + d981cfb
commit e586047
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/ttddbg/src/ttddbg_debugger_manager.cc b/ttddbg/src/ttddbg_debugger_manager.cc
@@ -498,9 +498,10 @@ namespace ttddbg
 
 	/**********************************************************************/
 	void DebuggerManager::populatePositionChooser() {
-		// TODO: use m_engine methods to add timeline positions for each:
-		// - Thread creation / exit
-		// - Module load / unload
+		if (m_cursor == NULL) {
+			warning("The Timeline is only available while debugging.");
+			return;
+		}
 
 		if (m_positionChooser->get_count() > 0) {
 			// If the position count is > 0 even before populating, it means that

diff --git a/ttddbg/src/ttddbg_position_chooser.cc b/ttddbg/src/ttddbg_position_chooser.cc
@@ -86,6 +86,11 @@ namespace ttddbg {
 
 	/**********************************************************************/
 	chooser_t::cbret_t PositionChooser::ins(ssize_t n) {
+		if (m_cursor == NULL) {
+			warning("Cannot insert a new position when not in debug mode");
+			return NOTHING_CHANGED;
+		}
+
 		qstring res;
 		bool ok = ask_str(&res, 0, "Name of the new position");