backtrace: add support for generic backtraces #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
generic-backtraces-support
branch
from
d7d5dd0 to
db57cdd
Compare
Sometimes exceptions can contain manual backtraces that quack similar to Ruby exceptions, but do not stricly adhere their template. I stumbled upon this issues, when I was working with SCSS. It sets a couple of custom first frames such as: ``` Sass::SyntaxError: Undefined mixin 'animation'. /home/app/assets/stylesheets/error_pages.scss:139:in `animation' /home/app/app/assets/stylesheets/error_pages.scss:139 ``` Previously, we were not able to parse the second frame. Furthermore, we now raise error if we cannot parse a stack frame to simplify debugguging and improving our parser.
kyrylo
force-pushed
the
generic-backtraces-support
branch
from
b937533 to
d778d92
Compare
| return match if match | ||
|
|
||
| unless (matched_frame = GENERIC_STACKFRAME_REGEXP.match(stackframe)) | ||
| raise Airbrake::Error, "failed parsing '#{stackframe}'" |
There was a problem hiding this comment.
Nitpick: "Failed parsing" assumes that there was some failure, but here we just "can't parse".
|
I don't understand who is responsible to parse |
According to: * #4 (comment) * #4 (comment)
|
Its backtrace: |
|
LGTM |
kyrylo
added a commit
that referenced
this pull request
Dec 18, 2015
backtrace: add support for generic backtraces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes exceptions can contain manual backtraces that quack similar to
Ruby exceptions, but do not stricly adhere their template. I stumbled
upon this issues, when I was working with SCSS. It sets a couple of
custom first frames such as:
Previously, we were not able to parse the second frame.
Furthermore, we now raise error if we cannot parse a stack frame to
simplify debugguging and improving our parser.