docs(xychart): add advanced usage sandbox examples #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 426653897Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
hshoff
approved these changes
Dec 17, 2020
| @@ -18,7 +18,7 @@ export type EventHandlerParams<Datum> = { | |||
| /** Coordinates of the event in svg space. */ | |||
| svgPoint?: { x: number; y: number }; | |||
| /** The PointerEvent or FocusEvent. */ | |||
| event: PointerEvent | FocusEvent; | |||
| event?: PointerEvent | FocusEvent; | |||
There was a problem hiding this comment.
added to the PR description. you had a commit message with it, but just want to make it lands in the 1.4 changelog as an enhancement
There was a problem hiding this comment.
good catch, thanks 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
📝 Documentation
This adds a few more codesandbox examples to the
@visx/xychartREADME, some demonstrating advanced usage of context providers:AnnotationexampleEventEmitterProviderexampleThemeProvider+ custom theme chart background exampleDataProvider/EventEmitterProviderexample of linked tooltips / small multiples, closes #800TooltipProviderexample of programmatic tooltip triggering🐛 Bug Fix
</details>in thexychartreadme@kristw @hshoff