Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shape/AreaClosed): set y0 when it equals zero #955

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

williaster
Copy link
Collaborator

🐛 Bug Fix

Fixes a small issue I noticed when answering #954 , we don't set y0 when it is 0 because of the truthy/falsy logic. A work around for now is to set y0={() => 0}

@kristw @hshoff
cc @puchm

@williaster williaster added this to the 1.2.1 milestone Dec 2, 2020
@williaster williaster requested review from hshoff and kristw December 2, 2020 02:05
@coveralls
Copy link

coveralls commented Dec 2, 2020

Pull Request Test Coverage Report for Build 395151044

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.864%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/visx-shape/src/shapes/AreaClosed.tsx 1 2 50.0%
Totals Coverage Status
Change from base Build 395106080: 0.0%
Covered Lines: 1634
Relevant Lines: 2571

💛 - Coveralls

@williaster williaster merged commit f5b7f84 into master Dec 2, 2020
@williaster williaster deleted the chris--fix-areaclosed-y0-check branch December 2, 2020 18:26
@williaster williaster modified the milestones: 1.2.1, 1.3.0 Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Prop for AreaClosed to specify in which direction area gets closed
3 participants