new(annotations/EditableAnnotation): add canEditSubject canEditLabel #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hshoff
requested changes
Nov 12, 2020
| onTouchStart={subjectDrag.dragStart} | ||
| onTouchMove={subjectDrag.dragMove} | ||
| onTouchEnd={subjectDrag.dragEnd} | ||
| cursor={subjectDrag.isDragging ? 'grabbing' : 'grab'} |
There was a problem hiding this comment.
Would we want this cursor state to configurable? maybe through subjectDragHandleProps?
There was a problem hiding this comment.
Yep! {...subjectDragHandleProps} is spread below this line so it should override cursor (tho currently it doesn't have access to subjectDrag state, is that what you meant?)
| onTouchStart={labelDrag.dragStart} | ||
| onTouchMove={labelDrag.dragMove} | ||
| onTouchEnd={labelDrag.dragEnd} | ||
| cursor={labelDrag.isDragging ? 'grabbing' : 'grab'} |
|
|
||
| describe('<EditableAnnotation />', () => { | ||
| function setup() { | ||
| function setup(props?: EditableAnnotationProps) { |
There was a problem hiding this comment.
Partial<EditableAnnotationProps>
Pull Request Test Coverage Report for Build 371265698
💛 - Coveralls |
kristw
approved these changes
Nov 20, 2020
|
gonna merge this, happy to address any remaining concerns in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
This PR adds the ability to specify whether one or both of the annotation subject or label are editable within
EditableAnnotation, to support different use cases. Updates the demo to show this functionality.@kristw @hshoff