Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): visx rebrand, move to github pages #890

Merged
merged 12 commits into from
Nov 5, 2020
Merged

Conversation

hshoff
Copy link
Member

@hshoff hshoff commented Oct 23, 2020

This was a part of the v1 release. Been delayed to get the PR out.

🐛 Bug Fix

🏠 Internal

  • feat(demo): move to github pages
  • fix(demo): add html lang attr for a11y
  • fix(demo): add aria-label to footer logos for a11y
  • deps(demo): bump next.js 9.4 => 9.5
  • deps(demo): remove react-ga
  • deps(demo): bump yarn.lock

@coveralls
Copy link

coveralls commented Oct 23, 2020

Pull Request Test Coverage Report for Build 344688573

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.5%) to 60.095%

Files with Coverage Reduction New Missed Lines %
packages/visx-xychart/src/utils/getScaledValueFactory.ts 1 69.23%
packages/visx-xychart/src/utils/getBarStackRegistryData.ts 2 82.61%
packages/visx-xychart/src/components/series/private/BaseBarGroup.tsx 3 75.83%
packages/visx-xychart/src/components/series/private/BaseBarStack.tsx 5 77.42%
Totals Coverage Status
Change from base Build 263: -0.5%
Covered Lines: 1549
Relevant Lines: 2445

💛 - Coveralls

@hshoff
Copy link
Member Author

hshoff commented Oct 23, 2020

Lighthouse audit (desktop) for homepage:

image

Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for landing this! 🚀

packages/visx-demo/src/components/Gallery/index.tsx Outdated Show resolved Hide resolved
packages/visx-demo/src/components/Meta.tsx Outdated Show resolved Hide resolved
packages/visx-demo/src/components/icons/GitHub.tsx Outdated Show resolved Hide resolved
packages/visx-demo/src/pages/home.tsx Show resolved Hide resolved
@hshoff hshoff merged commit eb9424e into master Nov 5, 2020
@hshoff hshoff deleted the harry-rebrand branch November 5, 2020 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants