Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(xychart): add AreaSeries + AnimatedAreaSeries #878

Merged
merged 9 commits into from
Oct 22, 2020
Merged

new(xychart): add AreaSeries + AnimatedAreaSeries #878

merged 9 commits into from
Oct 22, 2020

Conversation

williaster
Copy link
Collaborator

🚀 Enhancements

This PR

  • adds AreaSeries, AnimatedAreaSeries, and BaseAreaSeries for a common implementation
  • adds tests for new files
  • updates the xychart demo to group line + bar series separately.

new demo

renders horizontal negative values correctly

@kristw @techniq

@williaster williaster requested a review from kristw October 16, 2020 21:24
@coveralls
Copy link

coveralls commented Oct 17, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 323081305

  • 34 of 34 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 60.317%
Totals Coverage Status
Change from base Build 322842098: 0.3%
Covered Lines: 1494
Relevant Lines: 2378
💛 - Coveralls

@williaster williaster force-pushed the chris--xychart-animated-line branch from 1b12022 to 81044b8 Compare October 22, 2020 20:17
Base automatically changed from chris--xychart-animated-line to master October 22, 2020 20:28
@williaster williaster added this to the 1.1.1 milestone Oct 22, 2020
@williaster williaster merged commit b996a71 into master Oct 22, 2020
@williaster williaster deleted the chris--xychart-area branch October 22, 2020 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshoff hshoff hshoff approved these changes

@kristw kristw kristw approved these changes

Assignees
No one assigned
Labels
🚀enhancement @visx/xychart
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@williaster @coveralls @hshoff @kristw