test(xychart): add refined Tooltip, TooltipProvider tests #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
force-pushed
the
chris--xychart-refined-tooltip-tests
branch
from
8f96801
to
c7901b2
Compare
kristw
approved these changes
Oct 7, 2020
| }} | ||
| > | ||
| <Tooltip | ||
| resizeObserverPolyfill={ResizeObserver} |
There was a problem hiding this comment.
What happens if the polyfill is not passed?
There was a problem hiding this comment.
if it's not passed and it's not available globally on window, it will throw (this logic lives in react-use-measure). Throwing may seem extreme but I think it's the cleanest way to polyfill, we import it globally in @visx/responsive's ParentSize and have gotten negative feedback about it.
I think we just need to be clear about it in the docs like in @visx/tooltip + react-use-measure.
There was a problem hiding this comment.
ic. a bit more gear towards power users i guess.
If doc emphasizes it enough probably ok.
Perhaps can make it a bit more convenient later to do this once instead of passing to every Tooltip instance.
1 task
williaster
force-pushed
the
chris--xychart-refined-tooltip-tests
branch
from
c7901b2
to
8d01a95
Compare
williaster
added a commit
that referenced
this pull request
Oct 8, 2020
* new(tooltip/useTooltipInPortal): allow detectBounds overrid in component * new(xychart/Tooltip): add working crosshairs + point * internal(demo/xychart/ChartBackground): use innerWidth/Height * new(xychart): working multi-datum toolips * new(xychart/Tooltip): add snapTooltipToDatumX/Y * new(xychart): add showMultipleCircles support, debounce hideTooltip * new(demo/xychart): add tooltip controls * internal(xychart): cleanup * internal(xychart): cleanup * internal(xychart): memoize coordinate getter * type(xychart/TooltipContext): remove svgPoint * fix(xychart/TooltipContext): infer Datum type * new(xychart): circle => glyph * test(xychart): add refined Tooltip, TooltipProvider tests (#852) * test(xychart): add more Tooltip tests * test(xychart): add more TooltipProvider tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏠 Internal
Builds on #846, adding tests for the new
Tooltip+TooltipProviderfunctionality (new tests highlighted). Separated for review-ability.@kristw @hshoff