Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TooltipWithBounds] fix : overflowing its parent on small screens #837

Merged
merged 4 commits into from
Oct 12, 2020
Merged

[TooltipWithBounds] fix : overflowing its parent on small screens #837

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
355632d
[TooltipWithBounds] change logic to calculate position
LethalPants Oct 2, 2020
a719409
format : TooltipWithBounds
LethalPants Oct 2, 2020
96b7c90
[TooltipWithBounds] update: change boundary on width of parent; apply…
LethalPants Oct 4, 2020
44e6b46
fix: [tooltip] move to quadrant where least clipping happens
LethalPants Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions packages/visx-tooltip/src/tooltips/TooltipWithBounds.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,29 @@ function TooltipWithBounds({
let top = initialTop;

if (ownBounds && parentBounds) {
const placeTooltipLeft =
offsetLeft + ownBounds.right > parentBounds.right ||
offsetLeft + ownBounds.right > window.innerWidth;
let placeTooltipLeft = false;
let placeTooltipUp = false;

const placeTooltipUp =
offsetTop + ownBounds.bottom > parentBounds.bottom ||
offsetTop + ownBounds.bottom > window.innerHeight;
if (parentBounds.width) {
const rightPlacementClippedPx = left + offsetLeft + ownBounds.width - parentBounds.width;
const leftPlacementClippedPx = ownBounds.width - left - offsetLeft;
placeTooltipLeft =
rightPlacementClippedPx > 0 && rightPlacementClippedPx > leftPlacementClippedPx;
} else {
const rightPlacementClippedPx = left + offsetLeft + ownBounds.width - window.innerWidth;
const leftPlacementClippedPx = ownBounds.width - left - offsetLeft;
placeTooltipLeft =
rightPlacementClippedPx > 0 && rightPlacementClippedPx > leftPlacementClippedPx;
}

if (parentBounds.height) {
const bottomPlacementClippedPx = top + offsetTop + ownBounds.height - parentBounds.height;
const topPlacementClippedPx = ownBounds.height - top - offsetTop;
placeTooltipUp =
bottomPlacementClippedPx > 0 && bottomPlacementClippedPx > topPlacementClippedPx;
} else {
placeTooltipUp = top + offsetTop + ownBounds.height > window.innerHeight;
}

left = placeTooltipLeft ? left - ownBounds.width - offsetLeft : left + offsetLeft;
top = placeTooltipUp ? top - ownBounds.height - offsetTop : top + offsetTop;
Expand Down