Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grid): refactor imports to not cause de-optimization for esm bundlers #1298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(grid): refactor imports to not cause de-optimization for esm bundlers #1298

wants to merge 1 commit into from
+9 −5

Commits on Jul 30, 2021

  1. refactor(visx-grid): Refactor imports to not cause deoptimization for… 

    … esm bundlers.

When importing from `@visx/grid/lib/shapes/Line` it forces bundlers to use the CommonJS version instead the ECMAScript Module version which leads to larger bundle sizes due to lacking tree-shaking capabilities (commonjs uses `require` statements).

If the types are not exposed from the root barrel file they should reside in their own import as type imports will be omitted.
    Lukas Holzer committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    eaddcb6 View commit details
    Browse the repository at this point in the history