Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Fixing issue with table viz for table with no metrics (#5205) #53

Conversation

michellethomas
Copy link

@michellethomas michellethomas commented Jun 15, 2018

(cherry picked from commit b60ac5f)

@john-bodley @graceguo-supercat @timifasubaa

@codecov-io
Copy link

Codecov Report

Merging #53 into airbnb-master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##           airbnb-master      #53   +/-   ##
==============================================
  Coverage          63.66%   63.66%           
==============================================
  Files                260      260           
  Lines              19681    19681           
  Branches            1970     1970           
==============================================
  Hits               12530    12530           
  Misses              7142     7142           
  Partials               9        9
Impacted Files Coverage Δ
superset/assets/src/visualizations/table.js 9.73% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8887517...f57530c. Read the comment docs.

@michellethomas michellethomas merged commit 174ce1a into airbnb:airbnb-master Jun 15, 2018
@michellethomas michellethomas deleted the cherry_pick_table_no_metric_fix branch June 15, 2018 01:21
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
feat: Export `SupersetClientClass`
internal: Increase test coverage.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants