Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[cherry-picks] a few dashboard improvement PRs #109

Conversation

graceguo-supercat
Copy link
Collaborator

[dashboard] Update font style for markdown component (apache#5722)
[dashboard] Add alert on user delete root level tab (apache#5771)
update dashboard sidepane title (apache#5850)

@john-bodley @michellethomas @kristw

Copy link

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

Codecov Report

Merging #109 into airbnb-master will increase coverage by 0.01%.
The diff coverage is 76.92%.

Impacted file tree graph

@@                Coverage Diff                @@
##           airbnb-master     #109      +/-   ##
=================================================
+ Coverage          63.42%   63.43%   +0.01%     
=================================================
  Files                356      357       +1     
  Lines              22168    22195      +27     
  Branches            2498     2502       +4     
=================================================
+ Hits               14059    14080      +21     
- Misses              8097     8103       +6     
  Partials              12       12
Impacted Files Coverage Δ
.../src/dashboard/components/BuilderComponentPane.jsx 64.86% <ø> (ø) ⬆️
...ts/src/dashboard/components/gridComponents/Tab.jsx 82.43% <100%> (-3.87%) ⬇️
superset/assets/src/components/ModalTrigger.jsx 97.22% <100%> (+0.16%) ⬆️
.../src/dashboard/components/menu/WithPopoverMenu.jsx 82.45% <50%> (+0.31%) ⬆️
.../src/dashboard/components/DeleteComponentModal.jsx 86.95% <86.95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb4086...26c2f7c. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit 0ca12f8 into airbnb:airbnb-master Sep 13, 2018
@graceguo-supercat graceguo-supercat deleted the gg-CherryPickDashboardImprovementPRs branch September 13, 2018 17:31
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
* feat: implement smart number format

* test: add unit tests

* refactor: Rename number formats
BREAKING CHANGE: NumberFormat.xxx are renamed

* feat: Make smart number default formatter

* fix: add unit test

* refactor: move formatters outside
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants