Bump version of asn1crypto. (asn1crypto fails on macOS Catalina, due to loading unversioned /usr/lib/libcrypto.dylib) #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @gavinelder - thank you for this, but we are no longer accepting patches for master (v2.3.0). we're working solely on the release-3-0-0 branch now, as that will soon become the next stable release. that said, this v3 release has updated dependencies across the board and the asn1crypto package is no longer used at all. I'm going to close this out. |
|
@ryandeivert NP fully understood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to:
cc: @airbnb/streamalert-maintainers
related to:
resolves:
Background
wbond/asn1crypto#158
asn1crypto fails on macOS Catalina, due to loading unversioned /usr/lib/libcrypto.dylib
Changes
Upgrade asn1crypto in requirements.txt
Testing
confirmed all tests passed & deployed to cluster YMMV