Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark deprecated lifecycle method with UNSAFE #19

Closed
wants to merge 1 commit into from
Closed

mark deprecated lifecycle method with UNSAFE #19

wants to merge 1 commit into from

Conversation

birge
Copy link

@birge birge commented Aug 20, 2019

The noise this is causing in react 16.9 is a bit much, until a proper solution is resolved in #14 let's just mark it unsafe.

ljharb
ljharb requested changes Aug 20, 2019
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's a bit much, don't use v16.9 yet.

This would be a breaking change that drops support for React < 16.3, which is not acceptable at this time.

@birge
Copy link
Author

birge commented Aug 20, 2019

Project not ready to drop support for older versions.

@birge birge closed this Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birge @ljharb