Potential approaches for allowing mocked state #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
approved these changes
Aug 30, 2018
| stateStore.set(reducer) | ||
| when { | ||
| debugMode -> // Must use `set` to ensure the validated state is the same as the actual state used in reducer | ||
| // Do not use `get` since `getState` queue has lower priority and the validated state would be the state after reduced |
There was a problem hiding this comment.
these 2 comments are outdated. can you delete them?
|
I agree both approaches seem like they would work. I kind of like being able to have all the mock states for different view models in one place and a single place to enable/disable all of them though. |
|
Closed in favor or #81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing with some ways to mock out state for testing. Each commit here is a separate approach.
Use an intermediate mocker singleton to control all mocked state
6ffc9c7
Set a mock provider on the view model
d508554
Definitely want to avoid making it too easy to set state so people don't use this outside of testing.