Fixing #699 java.lang.SecurityException

[danpe]

Fixes #699

[elihart]

@danpe thanks for fixing, but this doesn't seem to compile

MavericksMockPrinter.kt:209:38 Unresolved reference: networkInfoReceiver

[elihart]

I think you need to do what context.registerReceiver(this, IntentFilter(ACTION_COPY_MAVERICKS_STATE)) does below? and that line should be replaced with this new code

[danpe]

Thank you @elihart my bad, fixed it.
Samsung just released Android 14 to all its flagship devices, so I believe we'll be seeing more and more crashes due to this...

[elihart]

Good to know, but since this is the mocking library it shouldn't be running in production. Do you need to change your configuration?

[danpe]

It is weird as even if I disable mocking completely it still crashes,

        MockableMavericks.initialize(
            mocksEnabled =false
            debugMode = false,
            applicationContext = this,
            //TODO maybe use other dispatchers
            viewModelCoroutineContext = Dispatchers.Default,
            stateStoreCoroutineContext = Dispatchers.Default
        )

Still crashes on startup...

[danpe]

Thank you! Can you also make a release please? 🙏

…

On Fri, Nov 3, 2023, 21:54 Eli Hart ***@***.***> wrote: Merged #700 <#700> into main. — Reply to this email directly, view it on GitHub <#700 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQKRIYEHYN33KTODKVGQ5DYCVDXZAVCNFSM6AAAAAA6YI3AFKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHA3DAMBUGEZTGMI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[elihart]

I can make a release next week. I'm still curious though, if you are seeing these crashes in production, if you should instead be changing your config to not run the mock printer code in prod builds

[danpe]

I can make a release next week. I'm still curious though, if you are seeing these crashes in production, if you should instead be changing your config to not run the mock printer code in prod builds

It is weird as even if I disable mocking completely it still crashes,

        MockableMavericks.initialize(
            mocksEnabled =false
            debugMode = false,
            applicationContext = this,
            //TODO maybe use other dispatchers
            viewModelCoroutineContext = Dispatchers.Default,
            stateStoreCoroutineContext = Dispatchers.Default
        )

Still crashes on startup...

[elihart]

That doesn't control the mock printer configuration. You must be calling registerMockPrinter somewhere in your app. Don't call it in production builds...

[danpe]

That doesn't control the mock printer configuration. You must be calling registerMockPrinter somewhere in your app. Don't call it in production builds...

Tbh, we don't call registerMockPrinter anywhere in our app, that why it is strange.

[elihart]

It seems like you'll want to figure out the root cause of why the mock printer is registering in your production app. Even if you apply this fix you still don't want the broadcast receiver starting in your prod app.

Look at how you might be using MockableMavericks.enableMockPrinterBroadcastReceiver, or manual instantiation of MavericksMockPrinter

[danpe]

Hi @elihart , thank you for responding.
TBH, I did Find All.. (Cmd+Shift+F) and tried looking for both enableMockPrinterBroadcastReceiver and MavericksMockPrinter in all my files and modules.

Nothing found.

[mlengy]

Hi @elihart, thanks for the fix. Currently running into this issue when attempting to target API 34 as well. Curious when a new release would be possible. Thanks!

[elihart]

I'll get a release out this week

[ArunYogeshwaran]

Thanks for this fix. It helped us when we upgraded our target SDK version to 34