Add sample app to demonstrate integration of Koin with MvRx #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bump Koin version 2.0.1 -> 2.1.6
friendoye
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #339.
This PR adds a new sample app, which showcases usage of Koin with MvRx. In this app custom
KoinMvRxViewModelFactorywas introduced, which delegates creation of specific ViewModel directly to Koin, rather than fetching each constructor parameter manually. Also, this sample, in many ways, is very similar to Dagger sample app.Finally, this PR addresses such issue as usage of custom Koin scopes during creation of ViewModel in
MvRxViewModelFactory. Because there might be a situation in Koin, when ViewModel's factory is tied to specific scope, there should be a way forMvRxViewModelFactoryto know, which scope should be used during creation. That's whycustomDataproperty was introduced inViewModelContext.Curious to hear WDYT about this PR!