Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: document validation for SSR #3096

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix: document validation for SSR #3096

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e987be
fix: document validation for SSR
IcaroG Jun 27, 2024
6f6ccd0
fix: correctly name custom rollup plugins
IcaroG Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,15 @@ const addNavigatorValidation = (options = {}) => {
}
}

const addDocumentValidation = (options = {}) => {
return {
name: 'inject-version',
renderChunk: (code) => {
return '(typeof document !== "undefined") && ' + code;
},
};
};

const noTreeShakingForStandalonePlugin = () => {
return {
name: 'no-treeshaking-for-standalone',
Expand Down Expand Up @@ -137,7 +146,8 @@ const plugins = [
// noTreeShakingForStandalonePlugin(),
injectVersion(),
addNavigatorValidation(),
]
addDocumentValidation(),
];
const pluginsWithTerser = [
...plugins,
terser(),
Expand Down