Remove Linux #error from Package.swift
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Jul 10, 2024
) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | minor | `from: "4.4.3"` -> `from: "4.5.0"` | --- ### Release Notes <details> <summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary> ### [`v4.5.0`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.5.0) [Compare Source](https://togithub.com/airbnb/lottie-spm/compare/4.4.3...4.5.0) #### New Features - Added drop shadow support to main thread rendering engine ([https://github.com/airbnb/lottie-ios/pull/2423](https://togithub.com/airbnb/lottie-ios/pull/2423)) - Added support for opacity text animators ([https://github.com/airbnb/lottie-ios/pull/2436](https://togithub.com/airbnb/lottie-ios/pull/2436)) - Added `LottieView` helper for configuring individual `LottieAnimationView` properties ([https://github.com/airbnb/lottie-ios/pull/2415](https://togithub.com/airbnb/lottie-ios/pull/2415)) #### Bug Fixes - Fixed issue where bezier paths could be closed incorrectly ([https://github.com/airbnb/lottie-ios/pull/2418](https://togithub.com/airbnb/lottie-ios/pull/2418)) - Fixed bug where font providers were ignored in precomposition layers in the main thread rendering engine ([https://github.com/airbnb/lottie-ios/pull/2439](https://togithub.com/airbnb/lottie-ios/pull/2439)) - Fixed issue where lottie-spm package could cause package operations to unexpectedly fail on Linux ([https://github.com/airbnb/lottie-spm/pull/27](https://togithub.com/airbnb/lottie-spm/pull/27)). #### Version Compatibility **Lottie now requires Xcode 15 / Swift 5.9 or later** ([https://github.com/airbnb/lottie-ios/pull/2400](https://togithub.com/airbnb/lottie-ios/pull/2400)). Our version support policy is that Lottie supports Swift / Xcode versions back to the minimum version that is permitted by Apple for submissions to the App Store. As of April 2024, this is Xcode 15 / Swift 5.9: https://developer.apple.com/news/?id=fxu2qp7b. **Full Changelog**: airbnb/lottie-ios@4.4.3...4.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
#error("Linux is currently not supported")error from our Package.swift.This was originally so Swift Package Index wouldn't list this package as supporting Linux. This is causing issues for folks though, since it prevents the Package.manifest from being parsed on Linux (e.g. in CI): airbnb/lottie-ios#2328
Rather than having this workaround to fix the Swift Package Index badge, let's just remove both.