Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for opacity text animators #2436

Merged
merged 8 commits into from
Jun 20, 2024
Merged

Conversation

calda
Copy link
Member

@calda calda commented Jun 17, 2024

This PR adds basic support for opacity text animators in the main thread rendering engine:

2024-06-17 10 50 02

2024-06-17 10 49 47

Copy link

emerge-tools bot commented Jun 17, 2024

1 build increased size

Name Version Download Change Install Change Approval
SizeTest
com.airbnb.lottie.sizetest.iOS
1.0 (1) 748.6 kB ⬆️ 3.8 kB (0.51%) 2.3 MB ⬆️ 11.7 kB (0.52%) N/A

SizeTest 1.0 (1)
com.airbnb.lottie.sizetest.iOS

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 11.7 kB (0.52%)
Total download size change: ⬆️ 3.8 kB (0.51%)

Largest size changes

Item Install Size Change
Lottie.TextAnimatorNodeProperties.init(textAnimator) ⬆️ 1.5 kB
Lottie.CoreTextRenderLayer.updateTextContent ⬆️ 1.5 kB
Lottie.TextAnimator.init(from) ⬆️ 1.1 kB
Lottie.TextAnimator.init(dictionary) ⬆️ 692 B
Other ⬆️ 6.9 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 10.00kB exceeded

@calda calda force-pushed the cal--opacity-text-animator branch from d30a60b to 4ec9ae0 Compare June 17, 2024 17:49
@calda calda marked this pull request as ready for review June 17, 2024 17:53
@calda calda force-pushed the cal--opacity-text-animator branch from 6fe0c43 to 8438072 Compare June 20, 2024 16:33
@calda calda enabled auto-merge (squash) June 20, 2024 16:37
@calda calda merged commit 0ed725e into master Jun 20, 2024
13 checks passed
@calda calda deleted the cal--opacity-text-animator branch June 20, 2024 18:31
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Jul 10, 2024
)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | minor |
`from: "4.4.3"` -> `from: "4.5.0"` |

---

### Release Notes

<details>
<summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary>

###
[`v4.5.0`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.5.0)

[Compare
Source](https://togithub.com/airbnb/lottie-spm/compare/4.4.3...4.5.0)

#### New Features

- Added drop shadow support to main thread rendering engine
([https://github.com/airbnb/lottie-ios/pull/2423](https://togithub.com/airbnb/lottie-ios/pull/2423))
- Added support for opacity text animators
([https://github.com/airbnb/lottie-ios/pull/2436](https://togithub.com/airbnb/lottie-ios/pull/2436))
- Added `LottieView` helper for configuring individual
`LottieAnimationView` properties
([https://github.com/airbnb/lottie-ios/pull/2415](https://togithub.com/airbnb/lottie-ios/pull/2415))

#### Bug Fixes

- Fixed issue where bezier paths could be closed incorrectly
([https://github.com/airbnb/lottie-ios/pull/2418](https://togithub.com/airbnb/lottie-ios/pull/2418))
- Fixed bug where font providers were ignored in precomposition layers
in the main thread rendering engine
([https://github.com/airbnb/lottie-ios/pull/2439](https://togithub.com/airbnb/lottie-ios/pull/2439))
- Fixed issue where lottie-spm package could cause package operations to
unexpectedly fail on Linux
([https://github.com/airbnb/lottie-spm/pull/27](https://togithub.com/airbnb/lottie-spm/pull/27)).

#### Version Compatibility

**Lottie now requires Xcode 15 / Swift 5.9 or later**
([https://github.com/airbnb/lottie-ios/pull/2400](https://togithub.com/airbnb/lottie-ios/pull/2400)).
Our version support policy is that Lottie supports Swift / Xcode
versions back to the minimum version that is permitted by Apple for
submissions to the App Store. As of April 2024, this is Xcode 15 / Swift
5.9: https://developer.apple.com/news/?id=fxu2qp7b.

**Full Changelog**:
airbnb/lottie-ios@4.4.3...4.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
@alisamili
Copy link

此 PR 在主线程渲染引擎中添加了对不透明文本动画器的基本支持:

2024-06-17 10 50 02 2024-06-17 10 50 02

2024-06-17 10 49 47 2024-06-17 10 49 47

hi,can u help me?
let replacements = ["#textnodea": getStringWithKey("KEY_xxxxa"), "#textnodeb": getStringWithKey("KEY_xxxxb")]
In 3.3.0, using DictionaryTextProvider (replacements), replace the internationalized multi-language key. In countries where Arabic is used, the text content is still displayed in English. Can this version solve this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants