Fix parsing regression in 4.3.0 from addition of parsing layer effects #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ptal @thedrick |
thedrick
approved these changes
Oct 16, 2023
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Dec 4, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | patch | `from: "4.3.3"` -> `from: "4.3.4"` | --- ### Release Notes <details> <summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary> ### [`v4.3.4`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.3.4) [Compare Source](https://togithub.com/airbnb/lottie-spm/compare/4.3.3...4.3.4) #### What's Changed - Fix parsing regression in 4.3.0 from addition of parsing layer effects by [@​calda](https://togithub.com/calda) in [https://github.com/airbnb/lottie-ios/pull/2208](https://togithub.com/airbnb/lottie-ios/pull/2208) - Remove old animation layer when creating a new animation layer by [@​junjielu](https://togithub.com/junjielu) in [https://github.com/airbnb/lottie-ios/pull/2214](https://togithub.com/airbnb/lottie-ios/pull/2214) - Add configuration setting to remove animated bounds changes by [@​thedrick](https://togithub.com/thedrick) in [https://github.com/airbnb/lottie-ios/pull/2218](https://togithub.com/airbnb/lottie-ios/pull/2218) - Change pod dependencies `SwiftUI` and `Combine` to `weak` to ensure compatibility with iOS 12 by [@​florianrhein](https://togithub.com/florianrhein) in [https://github.com/airbnb/lottie-ios/pull/2219](https://togithub.com/airbnb/lottie-ios/pull/2219) - Fix issue where Repeater would be ignored if not at top level by [@​calda](https://togithub.com/calda) in [https://github.com/airbnb/lottie-ios/pull/2221](https://togithub.com/airbnb/lottie-ios/pull/2221) - Replace `UIScreen.main` to get display scale on iOS 13.0 and later ([#​2215](https://togithub.com/airbnb/lottie-spm/issues/2215)) by [@​hyun99999](https://togithub.com/hyun99999) in [https://github.com/airbnb/lottie-ios/pull/2216](https://togithub.com/airbnb/lottie-ios/pull/2216) - Dispatch dot lottie file loading onto a single serial queue by [@​erichoracek](https://togithub.com/erichoracek) in [https://github.com/airbnb/lottie-ios/pull/2229](https://togithub.com/airbnb/lottie-ios/pull/2229) - Clean up unused property in InvertedMatteLayer by [@​hanton](https://togithub.com/hanton) in [https://github.com/airbnb/lottie-ios/pull/2241](https://togithub.com/airbnb/lottie-ios/pull/2241) - Fix issue where LottieView animation would restart from beginning after backgrounding app by [@​calda](https://togithub.com/calda) in [https://github.com/airbnb/lottie-ios/pull/2237](https://togithub.com/airbnb/lottie-ios/pull/2237) **Full Changelog**: airbnb/lottie-ios@4.3.3...4.3.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a parsing regression where an animation that was parsed successfully by 4.2.0 fails to parse in 4.3.0. This was because we now parse layer effects, which previously weren't parsed so could be invalid.
The fix is to be more generous with how we handle invalid layer effects. Instead of failing to parse the entire animation, we can just ignore the specific invalid effect.
Fixes #2206.