Update Core Animation rendering engine to use device RGB color space #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
commented
Nov 7, 2022
| @@ -103,8 +103,8 @@ private class MaskLayer: CALayer { | |||
| addSublayer(maskLayer) | |||
| anchorPoint = .zero | |||
| maskLayer.fillColor = mask.mode == .add | |||
| ? CGColor(colorSpace: CGColorSpaceCreateDeviceRGB(), components: [1, 0, 0, 1]) | |||
| : CGColor(colorSpace: CGColorSpaceCreateDeviceRGB(), components: [0, 1, 0, 1]) | |||
| ? .rgb(1, 0, 0) | |||
There was a problem hiding this comment.
Consolidated all CGColor.init call sites to the same helper
calda
force-pushed
the
cal--update-color-spaces
branch
from
765bad9 to
7ef726a
Compare
erichoracek
approved these changes
Nov 7, 2022
calda
added a commit
that referenced
this pull request
Nov 28, 2022
calda
added a commit
that referenced
this pull request
Dec 1, 2022
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Core Animation rendering engine to use the same color space as the Main Thread rendering engine (
CGColorSpaceCreateDeviceRGB()). Fixes #1800.Currently the Main Thread rendering engine and Core Animation rendering engine use different color spaces, which can cause the two engines to render colors differently. For consistency between the two implementations, we should use the same color space.
CGColorSpaceCreateDeviceRGB()produces the exact same color as the web player:CGColor(red:green:blue:alpha:)creates a lighter color in this case:Since
CGColorSpaceCreateDeviceRGB()is the existing behavior, and best matches other platforms, we should be using that instead.