Add rounded corner support to Core Animation rendering engine #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @johnny-duo |
calda
commented
Nov 2, 2022
| func roundCorners(radius: CGFloat) -> BezierPath { | ||
| guard radius > 0 else { |
There was a problem hiding this comment.
I had to remove this, because it caused artifacts when Core Animation tried to interpolate between a path with roundedCorners(radius: 0) to any other value. Even though path and path.roundedCorners(radius: 0) are visually identical, the individual points in the bezier curve are different.
| Before | After |
|---|---|
 |
 |
I added back the equivalent logic to the call site from the Main Thread rendering engine, which doesn't have this issue
calda
force-pushed
the
cal--core-animation-rounded-corners
branch
from
b258fb6 to
1e4036f
Compare
erichoracek
approved these changes
Nov 3, 2022
calda
added a commit
that referenced
this pull request
Nov 28, 2022
calda
added a commit
that referenced
this pull request
Dec 1, 2022
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds rounded corner support to the Core Animation rendering engine, following #1795 which added this support for the Main Thread rendering engine