Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace LRUAnimationCache with a thread-safe NSCache-based cache #1783

Merged
merged 5 commits into from
Oct 19, 2022

Conversation

marcelofabri
Copy link
Contributor

@marcelofabri marcelofabri commented Oct 19, 2022

Fixes #1774. Fixes #1410.

I think we should also change the default to use this new implementation as it can be surprising if the default implementation is not thread-safe.

@marcelofabri marcelofabri changed the title Add ThreadSafeAnimationCache Replace LRUAnimationCache with a thread-safe NSCache-based cache Oct 19, 2022
Copy link
Member

@calda calda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@calda calda enabled auto-merge (squash) October 19, 2022 13:59
@calda calda merged commit 818cf21 into airbnb:master Oct 19, 2022
MoroziOS pushed a commit to MoroziOS/tmg-lottie-ios that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LRUAnimationCache should be smarter? Race condition crash.
2 participants