Rename public types that conflict with SwiftUI types #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
force-pushed
the
cal--rename-public-types
branch
from
08e0b8b to
d7805c9
Compare
erichoracek
approved these changes
Oct 7, 2022
| @IBDesignable | ||
| final public class AnimationView: AnimationViewBase { | ||
| final public class LottieAnimationView: LottieAnimationViewBase { |
There was a problem hiding this comment.
Have you put any thought into what we'd name a SwiftUI View for Lottie animations? If both LottieAnimation and LottieAnimationView are taken I wonder what options we would have
There was a problem hiding this comment.
Good question, LottieView is a potential option. How have we been handling this in other cases, where we provide a UIView and SwiftUI View with the same functionality?
There was a problem hiding this comment.
Sure, I think LottieView would work!
This was referenced Oct 11, 2022
calda
added a commit
that referenced
this pull request
Nov 28, 2022
calda
added a commit
that referenced
this pull request
Dec 1, 2022
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
AnimationandColortoLottieAnimationandLottieColor, to resolve conflicts with theSwiftUIAnimationandColortypes. For consistency this PR also renamesAnimationViewtoLottieAnimationView.Fixes #1420.
We'll release Lottie 3.5 next week, with this being the only change from 3.4.4. This version includes typealiases for the old names, so there is no source breakage. Xcode emits a warning with a fix-it to update callsites to the new name.
In a few weeks we plan on releasing Lottie 4.0. We will remove the old typealiases, which will resolve the naming conflict with SwiftUI.