Use warn instead of assertionFailure when detecting repeater use #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderKvamme
changed the title
|
@calda Was this what you ment? This is my first open source contribution so be gentle 😅 |
|
Fixes #1739 |
|
@calda - is it possible to get a point release available on cocoapods with this fix? I understand it doesn't fix the root issue but at least it will stop our development builds from crashing. |
|
Sure, I'll release a new version soon. |
|
That would be amazing, thank you so much @calda . |
Happy Monday! Just bumping @calda - any approximate ETA? |
|
Released 3.4.4 with this change today |
|
Thanks so much @calda . :) |
calda
pushed a commit
that referenced
this pull request
Nov 28, 2022
… in Main Thread rendering engine (#1754)
calda
pushed a commit
that referenced
this pull request
Dec 1, 2022
… in Main Thread rendering engine (#1754)
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
… in Main Thread rendering engine (airbnb#1754)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on a fix discussed in #1739