Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break temporary retain cycle in system presentation style #40

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Break temporary retain cycle in system presentation style #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
in specific scenarios.
- Fixed an issue where the `accessibilityAlignment` property of `HGroup` was not being respected.
- Fixed an issue where `accessibilityAlignment` and `horizontalAlignment` would overwrite one another
- Break a temporary retain cycle in `.system` presentation style

### Changed
- `CollectionViewConfiguration.usesBatchUpdatesForAllReloads` now defaults to `true`.
Expand Down
4 changes: 2 additions & 2 deletions Sources/EpoxyPresentations/PresentationModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,10 +290,10 @@ extension PresentationModel.Presentation {
forName: .init("\(UIPresentationController.self)DismissalTransitionDidEndNotification"),
object: presented,
queue: .main,
using: { _ in
using: { [didDismiss = context.didDismiss] _ in
guard token != nil else { return }
token = nil
context.didDismiss()
didDismiss()
})

context.presenting.present(
Expand Down