Add flag to disable EpoxySwiftUIHostingController keyboard avoidance
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryankeller
approved these changes
Jul 23, 2024
brynbodayle
reviewed
Jul 23, 2024
| @@ -19,7 +19,7 @@ open class EpoxySwiftUIHostingController<Content: View>: UIHostingController<Con | |||
|
|
|||
| /// Creates a `UIHostingController` that optionally ignores the `safeAreaInsets` when laying out | |||
| /// its contained `RootView`. | |||
| public convenience init(rootView: Content, ignoreSafeArea: Bool) { | |||
| public convenience init(rootView: Content, ignoreSafeArea: Bool, ignoreKeyboardAvoidance: Bool) { | |||
There was a problem hiding this comment.
just realized both should be ignores for consistency
There was a problem hiding this comment.
If we rename the API, it'll be a breaking change. That's fine but just something to keep in mind since it will change the semver version when we tag another release off of master.
brynbodayle
approved these changes
Jul 23, 2024
auto-merge was automatically disabled
July 23, 2024 21:19
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
This PR fixes an issue where an
EpoxySwiftUIHostingViewused as a bottom bar was being pushed above the keyboard when presented causing layout issues with the screen. There doesn't seem to be a way to disable this from SwiftUI (.ignoresSafeArea(.keyboard)doesn't work) so this uses dynamic subclassing to override the hosting controller'skeyboardWillShowWithNotificationmethod.How was it tested?
How did you verify that this change accomplished what you expected? Add more detail as needed.
Pull request checklist
All items in this checklist must be completed before a pull request will be reviewed.
CollectionViewConfigurationCHANGELOG.mdentry in the "Unreleased" section for any library changes