Refine UIKit to SwiftUI Measurement Strategies #162
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,137 @@ | ||
| // Created by Bryn Bodayle on 2/5/24. | ||
| // Copyright © 2024 Airbnb Inc. All rights reserved. | ||
|
|
||
| import Epoxy | ||
| import SwiftUI | ||
| import UIKit | ||
|
|
||
| // MARK: - EpoxyInSwiftUISizingStrategiesViewController | ||
|
|
||
| /// Demo of the various sizing strategies for UIKit views bridged to SwiftUI | ||
| final class EpoxyInSwiftUISizingStrategiesViewController: UIHostingController<EpoxyInSwiftUISizingStrategiesView> { | ||
| init() { | ||
| super.init(rootView: EpoxyInSwiftUISizingStrategiesView()) | ||
| } | ||
|
|
||
| required init?(coder _: NSCoder) { | ||
| fatalError("init(coder:) has not been implemented") | ||
| } | ||
| } | ||
|
|
||
| // MARK: - EpoxyInSwiftUISizingStrategiesView | ||
|
|
||
| struct EpoxyInSwiftUISizingStrategiesView: View { | ||
|
|
||
| // MARK: Internal | ||
|
|
||
| let text = "The text" | ||
|
|
||
| var body: some View { | ||
| ScrollView { | ||
| LazyVStack(alignment: .leading, spacing: 12) { | ||
| Text("Word Count: \(wordCount)") | ||
| .padding() | ||
| Slider(value: $wordCount, in: 0...100) | ||
| .padding() | ||
| Text("Proposed Width/Height set to 150pt") | ||
| .padding() | ||
|
|
||
| ForEach(SwiftUIMeasurementContainerStrategy.allCases) { value in | ||
| Text(value.displayString) | ||
| .bold() | ||
| .padding() | ||
| LabelView( | ||
| text: BeloIpsum.sentence(count: 1, wordCount: Int(wordCount)), | ||
| measurementStrategy: value) | ||
| .frame(width: value.proposedWidth, height: value.proposedHeight) | ||
| .border(.red) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // MARK: Private | ||
|
|
||
| @State private var wordCount = 12.0 | ||
| } | ||
|
|
||
| // MARK: - SwiftUIMeasurementContainerStrategy + Identifiable, CaseIterable | ||
|
|
||
| extension SwiftUIMeasurementContainerStrategy: Identifiable, CaseIterable { | ||
|
|
||
| // MARK: Public | ||
|
|
||
| public static var allCases: [SwiftUIMeasurementContainerStrategy] = [ | ||
| .automatic, | ||
| .proposed, | ||
| .intrinsicHeightProposedOrIntrinsicWidth, | ||
| .intrinsicHeightProposedWidth, | ||
| .intrinsicWidthProposedHeight, | ||
| .intrinsic, | ||
| ] | ||
|
|
||
| public var id: Self { | ||
| self | ||
| } | ||
|
|
||
| // MARK: Internal | ||
|
|
||
| var displayString: String { | ||
| switch self { | ||
| case .automatic: | ||
| return "Automatic" | ||
| case .proposed: | ||
| return "Proposed" | ||
| case .intrinsicHeightProposedOrIntrinsicWidth: | ||
| return "Intrinsic Height, Proposed Width or Intrinsic Width" | ||
| case .intrinsicHeightProposedWidth: | ||
| return "Intrinsic Height, Proposed Width" | ||
| case .intrinsicWidthProposedHeight: | ||
| return "Intrinsic Width, Proposed Height" | ||
| case .intrinsic: | ||
| return "Intrinsic" | ||
| } | ||
| } | ||
|
|
||
| var proposedWidth: CGFloat? { | ||
| switch self { | ||
| case .proposed, .intrinsicHeightProposedWidth: | ||
| return 150 | ||
| default: | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| var proposedHeight: CGFloat? { | ||
| switch self { | ||
| case .proposed, .intrinsicWidthProposedHeight: | ||
| return 150 | ||
| default: | ||
| return nil | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // MARK: - LabelView | ||
|
|
||
| struct LabelView: UIViewConfiguringSwiftUIView { | ||
|
|
||
| let text: String? | ||
| let measurementStrategy: SwiftUIMeasurementContainerStrategy | ||
|
|
||
| var configurations = [SwiftUIView<UILabel, Void>.Configuration]() | ||
|
|
||
| var body: some View { | ||
| UILabel.swiftUIView { | ||
| let label = UILabel(frame: .zero) | ||
| label.numberOfLines = 0 | ||
| return label | ||
| } | ||
| .configure { context in | ||
| context.view.text = text | ||
| context.container.invalidateIntrinsicContentSize() | ||
| } | ||
| .configurations(configurations) | ||
| .sizing(measurementStrategy) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we fixed it for AppKit too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBD, waiting for some updates from @calda since Epoxy iOS doesn't officially support native macOS, but Lottie iOS pulls in the code and uses it directly for macOS.