Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Revert epoxy hosting view margin changes #160

Merged
merged 2 commits into from
Nov 8, 2023
Merged

[iOS] Revert epoxy hosting view margin changes #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de8156d
Revert Epoxy Hosting View layout margin changes
Nov 8, 2023
51e6833
Update CHANGELOG.md
Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
approach to resolve an issue that could cause collection view cells to layout with
unexpected dimensions
- Made new layout-based SwiftUI cell rendering option the default.
- Pin `EpoxySwiftUIHostingView` content to `layoutMarginsGuide` to ensure content respects the safe area
when installed in a `TopBarContainer` or `BottomBarContainer`.

## [0.10.0](https://github.com/airbnb/epoxy-ios/compare/0.9.0...0.10.0) - 2023-06-29

Expand Down
5 changes: 2 additions & 3 deletions Sources/EpoxyCore/SwiftUI/EpoxySwiftUIHostingView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ public final class EpoxySwiftUIHostingView<RootView: View>: UIView, EpoxyableVie
}
})
layoutMargins = .zero
insetsLayoutMarginsFromSafeArea = false
}

@available(*, unavailable)
Expand Down Expand Up @@ -346,11 +345,11 @@ public final class EpoxySwiftUIHostingView<RootView: View>: UIView, EpoxyableVie
viewController.view.leadingAnchor.constraint(equalTo: leadingAnchor),
// Pining the hosting view controller to layoutMarginsGuide ensures the content respects the top safe area
// when installed inside a `TopBarContainer`
viewController.view.topAnchor.constraint(equalTo: layoutMarginsGuide.topAnchor),
viewController.view.topAnchor.constraint(equalTo: topAnchor),
viewController.view.trailingAnchor.constraint(equalTo: trailingAnchor),
// Pining the hosting view controller to layoutMarginsGuide ensures the content respects the bottom safe area
// when installed inside a `BottomBarContainer`
viewController.view.bottomAnchor.constraint(equalTo: layoutMarginsGuide.bottomAnchor),
viewController.view.bottomAnchor.constraint(equalTo: bottomAnchor),
])

viewController.didMove(toParent: parent)
Expand Down
Loading