Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin hosting controller to the top of the layout margin guide #157

Conversation

miguel-jimenez-0529
Copy link
Contributor

@miguel-jimenez-0529 miguel-jimenez-0529 commented Nov 3, 2023

Pin hosting controller to the top of the layout margin guide to ensure that a SwiftUI View used as BarModel is rendered below the top or bottom edge of the safe area.

Before After
image (4) image (5)

Change summary

How was it tested?

How did you verify that this change accomplished what you expected? Add more detail as needed.

  • Wrote automated tests
  • Built and ran on the iOS simulator
  • Built and ran on a device

Pull request checklist

All items in this checklist must be completed before a pull request will be reviewed.

  • Risky changes have been put behind a feature flag, e.g. CollectionViewConfiguration
  • Added a CHANGELOG.md entry in the "Unreleased" section for any library changes

@brynbodayle brynbodayle merged commit ec2f2d8 into airbnb:master Nov 7, 2023
9 checks passed
miguel-jimenez-0529 added a commit to miguel-jimenez-0529/epoxy-ios that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants