Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove forcesEarlySwiftUIRendering flag and implementation #155

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Remove forcesEarlySwiftUIRendering flag and implementation #155

merged 1 commit into from
Oct 17, 2023

Conversation

brynbodayle
Copy link
Contributor

@brynbodayle brynbodayle commented Oct 17, 2023 •
edited
Loading

Change summary

  • removes this flag and updates the false given we've been testing this in the Airbnb app for a few weeks with no issues

How was it tested?

How did you verify that this change accomplished what you expected? Add more detail as needed.

  • Wrote automated tests
  • Built and ran on the iOS simulator
  • Built and ran on a device

Pull request checklist

All items in this checklist must be completed before a pull request will be reviewed.

  • Risky changes have been put behind a feature flag, e.g. CollectionViewConfiguration
  • Added a CHANGELOG.md entry in the "Unreleased" section for any library changes

thedrick
thedrick approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@thedrick thedrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @brynbodayle

@brynbodayle brynbodayle merged commit eeb182b into airbnb:master Oct 17, 2023
9 checks passed
@brynbodayle brynbodayle deleted the bb-launch-early-rendering-flag branch October 17, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedrick thedrick thedrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brynbodayle @thedrick