Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwiftUI] Adds forcesEarlySwiftUIRendering flag to fix SwiftUI Cell Sizing #153

Merged

Conversation

brynbodayle
Copy link
Contributor

@brynbodayle brynbodayle commented Sep 21, 2023

Change summary

How was it tested?

How did you verify that this change accomplished what you expected? Add more detail as needed.

  • Wrote automated tests
  • Built and ran on the iOS simulator
  • Built and ran on a device

Pull request checklist

All items in this checklist must be completed before a pull request will be reviewed.

  • Risky changes have been put behind a feature flag, e.g. CollectionViewConfiguration
  • Added a CHANGELOG.md entry in the "Unreleased" section for any library changes


// MARK: - SwiftUIRenderingConfigurable

public protocol SwiftUIRenderingConfigurable: AnyObject {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary to cast to this since EpoxySwiftUIHostingView uses generics

@MichaelGofron
Copy link

@brynbodayle did you check in app that we're sending the right image size with these changes? I'd recalled having some issues with the render being called before the boolean flag was set when I was passing through the collection view configuration so just want to make sure we've tested the carousel case.

@brynbodayle brynbodayle force-pushed the mg--diagnose-hostingController-sizing branch from 531ceb7 to ebc3c13 Compare September 21, 2023 23:50
@brynbodayle brynbodayle force-pushed the mg--diagnose-hostingController-sizing branch from ebc3c13 to 020105b Compare September 22, 2023 00:44
@brynbodayle brynbodayle merged commit bb59fcc into airbnb:master Sep 22, 2023
9 checks passed
@brynbodayle brynbodayle deleted the mg--diagnose-hostingController-sizing branch September 22, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants