Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to babel 7 #37

Merged
merged 5 commits into from
Oct 8, 2018
Merged

Updated to babel 7 #37

merged 5 commits into from
Oct 8, 2018

Conversation

vikr01
Copy link
Contributor

@vikr01 vikr01 commented Sep 9, 2018

  • Updated all babel dependencies
  • context seems to no longer be part of babel functions, instead it's api and can't be null -- so I had to pass that down to @babel/preset-env Calling the function was not needed anymore.
  • Now using the new development option on @babel/preset-react when envName is development
  • Dropped support for node@<=4
  • Updated tests-only script to run index.js

 - set default to true if process.env.NODE_ENV is 'development'
 - add api.cache.using for babel to re-eval based on changes to NODE_ENV
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@davalapar
Copy link

Oh my fucking gawd, here it is.

Sir @ljharb would love to hear your feedback on this! ❤️ 💟 ❤️

@bjankord
Copy link

Interested to see this merged so airbnb/babel-plugin-dynamic-import-node#64 can get merged and then facebook/create-react-app#4984 can get merged. Nice work @vikr01 updating all these things!

@ajkl2533
Copy link

Would be awesome to merge this and unblock facebook/create-react-app#4984 :)

package.json Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
@ljharb
Copy link
Collaborator

ljharb commented Oct 1, 2018

Let's also remove node <= 4 from travis.yml.

index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased the commits down a bit. Remaining issues:

index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@Coder-256
Copy link

Many thanks to everybody for their work here! Just wondering, is this expected to be merged soon? airbnb/babel-plugin-dynamic-import-node#64 and vuejs/vue-cli#2642 appear to be all be waiting on this, in addition to some other projects mentioned above. I understand that it is important not to rush major changes like these, but until this is merged, many projects will be unable to upgrade to Babel 7 (which has been out for a bit now). No pressure, especially not on Columbus Day weekend, just looking for an ETA 😃

@ljharb
Copy link
Collaborator

ljharb commented Oct 6, 2018

@Coder-256 yes, you're right that this PR is blocking those. The hope is to merge and release it soon, but it can't be hurried by asking :-)

index.js Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the feature/babel-7 branch 5 times, most recently from e840d1c to d6ef4b8 Compare October 8, 2018 22:28
@kibertoad
Copy link

Woohoo! Is a new version with this planned for release?

@ljharb
Copy link
Collaborator

ljharb commented Oct 8, 2018

@kibertoad v3 is released.

@vikr01 vikr01 mentioned this pull request Oct 9, 2018
@vikr01 vikr01 deleted the feature/babel-7 branch April 20, 2019 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants