-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to babel 7 #37
Conversation
- set default to true if process.env.NODE_ENV is 'development' - add api.cache.using for babel to re-eval based on changes to NODE_ENV
d294bf2
to
64bce36
Compare
Oh my fucking gawd, here it is. Sir @ljharb would love to hear your feedback on this! ❤️ 💟 ❤️ |
Interested to see this merged so airbnb/babel-plugin-dynamic-import-node#64 can get merged and then facebook/create-react-app#4984 can get merged. Nice work @vikr01 updating all these things! |
Would be awesome to merge this and unblock facebook/create-react-app#4984 :) |
Let's also remove node <= 4 from travis.yml. |
71aea26
to
b0becc3
Compare
f18ecfe
to
6d3e01f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebased the commits down a bit. Remaining issues:
93ef4bb
to
69cd6cf
Compare
69cd6cf
to
e6d7589
Compare
3145842
to
ebb67c2
Compare
Many thanks to everybody for their work here! Just wondering, is this expected to be merged soon? airbnb/babel-plugin-dynamic-import-node#64 and vuejs/vue-cli#2642 appear to be all be waiting on this, in addition to some other projects mentioned above. I understand that it is important not to rush major changes like these, but until this is merged, many projects will be unable to upgrade to Babel 7 (which has been out for a bit now). No pressure, especially not on Columbus Day weekend, just looking for an ETA 😃 |
@Coder-256 yes, you're right that this PR is blocking those. The hope is to merge and release it soon, but it can't be hurried by asking :-) |
e840d1c
to
d6ef4b8
Compare
Woohoo! Is a new version with this planned for release? |
@kibertoad v3 is released. |
babel
dependenciesCalling the function was not needed anymore.context
seems to no longer be part of babel functions, instead it'sapi
and can't benull
-- so I had to pass that down to@babel/preset-env
development
option on@babel/preset-react
whenenvName
isdevelopment
node@<=4
tests-only
script to runindex.js