Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #4073 to 1.18.3 #5

Conversation

drmorr0
Copy link

@drmorr0 drmorr0 commented Nov 11, 2021

Backport of upstream PR caching launchtemplates for AWS (kubernetes#4073)

Testing done

  • Unit tests
  • Ran the backport in test-mc-a and confirmed the number of AWS API calls goes down:

Screen Shot 2021-11-11 at 11 03 08 AM

Reviewers

@evansheng @jiancheung

@drmorr0 drmorr0 force-pushed the david_morrison--cluster-autoscaler-patch-cluster-autoscaler-1.18.3-airbnb2 branch from 671c02a to 91523fa Compare November 11, 2021 17:03
…launch-templates

cache ASG InstanceTypes for AWS
@drmorr0 drmorr0 force-pushed the david_morrison--cluster-autoscaler-patch-cluster-autoscaler-1.18.3-airbnb2 branch from 91523fa to 7f02509 Compare November 11, 2021 18:07
Copy link
Collaborator

@evansheng evansheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drmorr0 drmorr0 merged commit ca6669a into cluster-autoscaler-release-1.18-airbnb Nov 11, 2021
drmorr0 added a commit that referenced this pull request Jan 13, 2022
…patch-cluster-autoscaler-1.18.3-airbnb2

Backport kubernetes#4073 to 1.19.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants