backport allowing specifying multiple expanders patch #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow specification of multiple expanders -- EDIT: change uses of scheduler/schedulerframework to scheduler/nodeinfo, as we are not yet on the version that switches
The github action hooks didn't run the unit tests on the expanders update in kubernetes#4233 (likely the known "tests don't run automatically for new contributor" limitation). NewStrategy became NewFilter, with a BestOptions (plural) method, and returns a Options slice instead of a single Option.
drmorr0
approved these changes
Dec 3, 2021
drmorr0
pushed a commit
that referenced
this pull request
Jan 13, 2022
…ch-cluster-autoscaler-1.18.3-airbnb4 backport allowing specifying multiple expanders patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From kubernetes#4233
and kubernetes#4354
@drmorr0