Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get a query parameter that contains the brackets #59

Merged
merged 2 commits into from
Nov 10, 2015

Conversation

mapyo
Copy link
Contributor

@mapyo mapyo commented Nov 2, 2015

Thank you for this great library!

I could not get a query parameter that contains the brackets.

For example,

airbnb://foo/baz?marsh[max]=mallow

marsh[max] is null.

The reason for this, please refer to the following.

https://github.com/airbnb/DeepLinkDispatch/blob/759cd16/deeplinkdispatch-processor/src/test/resources/DeepLinkActivity.java#L41

sample

import android.net.Uri;

String urlString = "airbnb://foo/baz?marsh[max]=mallow";
Uri uri = Uri.parse(urlString);

uri.getQueryParameter("marsh[max]");  // null

uri.getQueryParameterNames(); // can get key(marsh[max])

android.net.Uri package can not get a query parameter that contains the brackets.

For this reason, I have sent a pull request.

Thank you.

@mapyo mapyo force-pushed the fix-queryparams-bracket branch from f7b0ca3 to 2fec5d8 Compare November 3, 2015 07:28
@felipecsl
Copy link
Collaborator

I think we can probably fix this by using DeepLinkUri to parse the intent data query parameters instead of android.net.Uri. That solution would be preferable since it's simpler. Please feel free to give it a shot and update the PR

@mapyo
Copy link
Contributor Author

mapyo commented Nov 10, 2015

@felipecsl
Thank you for your comment!
I updated this PR.

Please confirm :octocat:

@felipecsl
Copy link
Collaborator

Nice! Looking great, thanks @mapyo
Last thing, please rebase the commits then I'll go ahead and merge it.

@mapyo mapyo force-pushed the fix-queryparams-bracket branch from 6ed0a92 to eb67225 Compare November 10, 2015 23:09
@mapyo
Copy link
Contributor Author

mapyo commented Nov 10, 2015

@felipecsl
I rebased.
Thank you!

felipecsl added a commit that referenced this pull request Nov 10, 2015
Get a query parameter that contains the brackets
@felipecsl felipecsl merged commit 9c61a6b into airbnb:master Nov 10, 2015
@felipecsl
Copy link
Collaborator

Perfect. Thanks a lot!

@mapyo
Copy link
Contributor Author

mapyo commented Nov 11, 2015

😄

@mapyo
Copy link
Contributor Author

mapyo commented Nov 12, 2015

@felipecsl
When is it scheduled to be released?

@felipecsl
Copy link
Collaborator

@mapyo we don't have a specific date yet, but I believe 1.5.0 should be out sometime later this month.
In the meantime you can use the snapshot version 1.5.0-SNAPSHOT

@mapyo
Copy link
Contributor Author

mapyo commented Nov 12, 2015

Thank you!

@mapyo mapyo deleted the fix-queryparams-bracket branch November 13, 2015 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants