Unity integration - FixedPoint / BlockHeaderValidators #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AionJayT
force-pushed
the
unity-master
branch
from
f83471a to
8cc7519
Compare
AionJayT
commented
Sep 17, 2019
| this.value = value; | ||
| } | ||
|
|
||
| public FixedPoint(BigDecimal value) { |
There was a problem hiding this comment.
also use the string directly, add comment
AionJayT
commented
Sep 17, 2019
|
|
||
| public BigDecimal toBigDecimal() { | ||
|
|
||
| BigDecimal maxPrecision = new BigDecimal(BigInteger.ONE.shiftLeft(PRECISION)); |
There was a problem hiding this comment.
use MAX_PRECISION directly
AionJayT
commented
Sep 17, 2019
|
|
||
| // This class can NOT be used for negative values | ||
|
|
||
| public class FixedPoint { |
AionJayT
commented
Sep 17, 2019
| public static final FixedPoint ZERO = new FixedPoint(BigInteger.ZERO); | ||
| public static final FixedPoint ONE = new FixedPoint(BigInteger.ONE.shiftLeft(PRECISION)); | ||
|
|
||
| private BigInteger value; |
AionJayT
commented
Sep 17, 2019
| return multiplyInteger(BigInteger.valueOf(multiplicand)); | ||
| } | ||
|
|
||
| public FixedPoint divideInteger(BigInteger divisor) { |
AionJayT
commented
Sep 17, 2019
| // This test calculates the logs for all integers from 1 to 2^20, and records how many of them | ||
| // end up with the same value. That is, it records how many x /= y satisfy log(x) = log(y) using our approximator | ||
| @Test | ||
| public void testCollisions() { |
AionJayT
commented
Sep 17, 2019
| @@ -44,6 +47,7 @@ | |||
| import org.aion.zero.impl.valid.AionExtraDataRule; | |||
| import org.aion.zero.impl.valid.AionHeaderVersionRule; | |||
| import org.aion.zero.impl.valid.EnergyConsumedRule; | |||
| import org.aion.zero.impl.valid.EquihashSolutionRule; | |||
AionJayT
commented
Sep 17, 2019
|
|
||
| public void logErrors(final Logger logger, final List<RuleError> errors) { | ||
| void logErrors(final Logger logger, final List<RuleError> errors) { |
There was a problem hiding this comment.
call it statically
AionJayT
commented
Sep 17, 2019
| @@ -3,12 +3,15 @@ | |||
| import java.util.List; | |||
| import org.aion.mcf.blockchain.BlockHeader; | |||
|
|
|||
| public abstract class GrandParentDependantBlockHeaderRule | |||
| extends AbstractValidRule { | |||
| public abstract class GrandParentDependantBlockHeaderRule extends AbstractValidRule { | |||
There was a problem hiding this comment.
make it an interface
AionJayT
force-pushed
the
unity-master
branch
from
8cc7519 to
fc61a48
Compare
- FixedPoint represents non-integral numbers by multiplying them by a large power of 2. - LogApproximator approximates the natural log of integers using a shift-and-add algorithm. The returned value is a FixedPoint.
AionJayT
force-pushed
the
unity-master
branch
from
fc61a48 to
241877e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
Please submit your PR to the
masterbranch and rebase your code onmasterbefore opening the pull request.Description
Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.
Fixes Issue # .
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.