Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and detaching modMcf from modDbImpl #976

Merged
merged 7 commits into from
Sep 6, 2019
Merged

Conversation

AlexandraRoatis
Copy link
Contributor

Description

  • Removed unnecessary type variable from Serializer
  • DataSourceArray can no longer be accessed outside the db module:
    • Knowledge of the sizeKey is removed from external tests.
    • Internal module tests check for correct storage of the size key in exceptional error cases that may cause it to miss from the database.
    • Removed the use of Flushable interface which will be removed once all implementations are updated.
  • ObjectDataSource can no longer be accessed outside the db module:
    • Removed reliance on Flushable interface.
    • Made implementations visible only inside the package.
  • Removed Flushable interface (superfluous design).
    • Flush functionality inside PendingBlockStore was not needed and therefore removed.
  • Removed unused flushCopiesTo method from AionRepositoryCache
  • Removed unused return type form createAccount method in RepositoryCache.
  • Removed some implementation-specific functionality from ContractDetails:
    • Removed DetailsProvider from configuration (superfluous design)
    • ContractDetailsCacheImpl no longer pretends to implement functionality to fit the interface.
    • modMcf dependency on modDbImpl is no longer required.

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

 - Knowledge of the sizeKey is removed from external tests.
 - Internal module tests check for correct storage of the size key in
 exceptional error cases that may cause it to miss from the database.
 - Removed the use of Flushable interface which will be removed once
 all implementations are updated.
 - Removed reliance on Flushable interface.
 - Made implementations visible only inside the package.
 - Flush functionality inside PendingBlockStore was not needed and therefore removed.
 - Removed DetailsProvider from configuration (superfluous design).
 - ContractDetailsCacheImpl no longer pretends to implement functionality to fit the interface.
 - modMcf dependency on modDbImpl is no longer required.
@AlexandraRoatis AlexandraRoatis merged commit 3aa31bf into master Sep 6, 2019
@AlexandraRoatis AlexandraRoatis deleted the ale-aki237 branch September 6, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant