Consensus and fork unit tests #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The block contains FVM contract deployments and subsequent calls that can cause issues if the vm type is not managed properly.
- The blocks contain the deployment and calls to an FVM contract that creates other contracts using internal transactions which are also called in these examples.
- Ensures that if a side-chain block is imported after a main-chain block, creating the same contract address X but using different VMs, then each chain will operate on the correct VM. - Corrected bug where the performed code was not retrieved when using a repository snapshot and a contract details cache.
|
LGTM and thanks for the bug fix. |
AionJayT
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):