Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dummy repo in the kernel precompiledContract module and fvm module #880

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

AionJayT
Copy link
Collaborator

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

  • To avoid redundant implementation when the repo interfaces change. We decide to remove the dummyRepo and to use the real implementation classes to execute the test suites.
  • The fvm changes are waiting for @iamyulong confirm it.

Fixes Issue # .

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • Update the test cases
  • Ignore the TRS precompiledContract test suites, cause currently, we don't run the precompiled TRS in the network.

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AionJayT AionJayT added enhancement New feature or request wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions labels Apr 15, 2019
@AionJayT AionJayT added this to the 0.4.0 milestone Apr 15, 2019
@AionJayT AionJayT self-assigned this Apr 15, 2019
@AionJayT AionJayT removed the wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions label Apr 25, 2019
@AlexandraRoatis AlexandraRoatis merged commit e46e2e2 into master-pre-merge Apr 26, 2019
@AionJayT AionJayT deleted the remove-dummyRepo branch May 2, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants