Step 11: kernel integration (put / delete split in contract details) #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed one of the set storage methods because it was not used
…nter exceptions on print
AlexandraRoatis
force-pushed
the
step-11
branch
from
b9601bb to
bfe1381
Compare
AlexandraRoatis
force-pushed
the
step-11
branch
from
bfe1381 to
e29722f
Compare
aion-kelvin
approved these changes
Feb 6, 2019
| } | ||
|
|
||
| // never used |
There was a problem hiding this comment.
We may want to remove the full class, cause there are multiple classes used for repository test functionality. But this feels like a separate task.
There was a problem hiding this comment.
If this is the test class that ends up remaining after refactoring, the functionality may be reenabled.
| /** | ||
| * Sets the storage to contain the specified key-value mappings. | ||
| * | ||
| * @param storage The specified mappings. | ||
| * @param storage the specified mappings | ||
| * @apiNote Used for testing. |
There was a problem hiding this comment.
I marked the fact that it was only used for testing so that maybe it gets removed from the interface during the refactoring. Then the tag can be added to the implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Last important integration step. Separating the put and delete in contract details to later allow the AVM to put bute arrays that are all 0 values.
Requires changes in aion_fastvm.
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
ContractDetailsCacheImplbehaves correctly on put and deleteVerification
Insert x into the following checkboxes to confirm (eg. [x]):