Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing 0 as a transaction type for the FVM #805

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

AlexandraRoatis
Copy link
Contributor

Description

Adding 0 as a valid transaction type value to avoid consensus breaks with Rust kernel.

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

  • the existing test suite and sync tests on mastery

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AlexandraRoatis AlexandraRoatis added the bug Something isn't working label Feb 4, 2019
@AlexandraRoatis AlexandraRoatis added this to the 0.3.3 milestone Feb 4, 2019
@AlexandraRoatis AlexandraRoatis merged commit c19de42 into master-pre-merge Feb 5, 2019
@AlexandraRoatis AlexandraRoatis deleted the fvm-tx-types branch February 5, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants