Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config migration #718

Merged
merged 5 commits into from
Nov 22, 2018
Merged

Config migration #718

merged 5 commits into from
Nov 22, 2018

Conversation

AlexandraRoatis
Copy link
Contributor

@AlexandraRoatis AlexandraRoatis commented Nov 21, 2018

Description

Automatically migrates the old kernel configurations as follows:

  1. check if config/config.xml exists:
  2. if no, it's already a new kernel and no changes are necessary;
  3. if yes:
    i. read the file located at config/config.xml;
    ii. check the network id in the config and match it to the available networks: conquest, mainnet, mastery, or custom;
    iii. delete config/config.xml and config/genesis.json;
    iv. overwrite [network]/config/config.xml with the read configuration;
    v. set database, log and keystore to absolute path based on the location read from the old config.

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • existing test suite
  • updated tests for new behavior
  • manual checks to verify that the configuration files get correctly copied and deleted, the absolute path to the keystore is added and the paths to the database and logs are set to absolute.

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AlexandraRoatis AlexandraRoatis added enhancement New feature or request wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions labels Nov 21, 2018
@AlexandraRoatis AlexandraRoatis added this to the 0.3.2 milestone Nov 21, 2018
@AlexandraRoatis AlexandraRoatis removed the wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions label Nov 22, 2018
@AlexandraRoatis AlexandraRoatis force-pushed the AIP_config_migration branch 2 times, most recently from 33c328b to 2a19f3e Compare November 22, 2018 19:11
Copy link
Collaborator

@AionJayT AionJayT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AionJayT AionJayT merged commit 4b8f728 into AIP_forkproperties Nov 22, 2018
@AlexandraRoatis AlexandraRoatis deleted the AIP_config_migration branch November 22, 2018 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants