Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP forkproperties #710
AIP forkproperties #710
Changes from 14 commits
99de446
7ed73f0
fc6fc9e
0dc8939
17dd8b1
74aded9
d4e0ad1
1747549
41da690
fe2780b
36a39c7
756b0c0
caae18e
e0e7adf
1fec69e
9f7348d
02f917a
8d49e96
a752293
a89e939
21a51b1
454f0db
3dbe09c
19e5f8a
7497336
2a19f3e
4b8f728
1774aa7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need a test for behavior with old kernels config using the variable above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disable to support the old config compatibility for the fork. And will put it in the release note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fork files need to be initialized for the case where the config files reside directly in the config folder as used by old kernels (implemented in
else
clause at line 210 above). I propose that we assume that anyone using the old config location takes the time to copy thefork.properties
file.