Improve API response to sendTransaction calls #678
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The API currently doesn't provide very meaningful responses when sendTransaction() is called. This PR improves the responses it send back. Note that lots of the functionality provided in this PR isn't currently used, but might be helpful in the future. For example, whether a transaction is successfully sent, or already sealed, or repaid, the API still just responds with the hash in all cases. However, this PR lets the API distinguish between these cases, so in the future it would be easy to let the user know what happened.
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
Modified the existing modApiServer sendTransaction test. Testing of the PendingState changes is desirable, but hard to implement, so it's not included in this PR.
Verification
Insert x into the following checkboxes to confirm (eg. [x]):