Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put Zero address if no from address supplied #654

Merged
merged 3 commits into from
Sep 27, 2018

Conversation

arajasek
Copy link
Contributor

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

If the API's estimateGas function is called without a from address, the VM uses the wrong offset when serialising. The fix is to simply use the Zero Address instead.

Fixes Issue #642

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

All existing tests pass

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@arajasek arajasek changed the title Apiserver bugfix2 Put Zero address if no from address supplied Sep 27, 2018
@AionJayT AionJayT merged commit 840bf7c into master-pre-merge Sep 27, 2018
@arajasek arajasek deleted the apiserver_bugfix2 branch September 28, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants