Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix p2p-in spin #639

Merged
merged 3 commits into from
Sep 25, 2018
Merged

fix p2p-in spin #639

merged 3 commits into from
Sep 25, 2018

Conversation

AionJayT
Copy link
Collaborator

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

It is a regression bug during the p2p refactoring. It will cause the p2p-in thread to occupy whole thread usage.

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Deploy the fixed node to the network, and then see the cpu usage significantly drop.

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AionJayT AionJayT added the bug Something isn't working label Sep 14, 2018
@AionJayT AionJayT added this to the 0.3.2 milestone Sep 14, 2018
@AionJayT AionJayT changed the base branch from master to master-pre-merge September 14, 2018 18:29
@AionJayT AionJayT mentioned this pull request Sep 14, 2018
12 tasks
@AionJayT AionJayT merged commit a66faee into master-pre-merge Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants