-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rpc Server Reliability Upgrades #619
Merged
+503
−191
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b34fcca
rpc server reliability upgrades
ali-sharif eface81
style and import fixes
ali-sharif 6751f1b
make makeSecure() access private in NanoRpcServer.java
ali-sharif c233761
removed unnecessary throws clause from AionUndertowRpcHandler.java
ali-sharif 3629342
added link to rpc configuration wiki in config file
ali-sharif File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
added link to rpc configuration wiki in config file
- v2mastery-sep16
- v1.6.2
- v1.6.1
- v1.6
- v1.5.1
- v1.5
- v1.4.1
- v1.4
- v1.3
- v1.2.1
- v1.2
- v1.1
- v1.0
- v1.0-rc2
- v1.0-rc1
- v0.4.2.0
- v0.4.1.1
- v0.4.1
- v0.4.0.2
- v0.4.0.1
- v0.4.0
- v0.4.0-rc2
- v0.4.0-rc
- v0.3.4.1
- v0.3.4
- v0.3.3
- v0.3.2.1
- v0.3.2
- v0.3.1
- v0.3.1.q
- unity-sep13
- tetryon-191116
- tetryon-191108
- rm
- ncc-review-2019Oct18
- ci-sync
- avmtestnet-03-26-2019
- avmtestnet-03-05-2019
- avmtestnet-02-08-2019
- avmtestnet-02-01-2019
- avmtestnet-01-30-2019
- analysis-t3
- amity-testnet-sep17
- amity-2019Sep25
- amity-2019Oct22
- amity-2019Oct16
- V1.5
- 04-17-2019-avmtestnet
- 1.4.1
commit 36293426f63b4ca79816d0280cc7a6603ff1f5ca
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why weren't the other configuration options added here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As is stated in the RPC docs, the other settings are for advanced users and putting them in the config would just give users opportunity to tweak those settings without really knowing what those settings do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the advanced config settings for the rpc-server will disappear after executing./aion.sh -c
Is that an expected behavior?