Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local.storage.dir flag #516

Merged
merged 2 commits into from
Jun 7, 2018
Merged

Conversation

centrys-victor
Copy link

Description

Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

  • Add local.storage.dir flag to change the storage location of the keystore

Fixes Issue #506 .

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@centrys-victor
Copy link
Author

@AionJayT

@qoire qoire requested review from AionJayT and qoire June 4, 2018 16:34
@qoire qoire added this to the v0.2.9 - Moldoveanu Peak milestone Jun 4, 2018
if (storageDir == null || storageDir.equalsIgnoreCase("")) {
storageDir = System.getProperty("user.dir");
}
KEYSTORE_PATH = storageDir + "/keytstore";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@qoire
Copy link
Contributor

qoire commented Jun 5, 2018

Let me verify the intent here @centrys-victor , this change is made in such a way that:

  • Setting the local.storage.dir property, as we will presumably do in the wallet to change the path
  • Not setting the local.storage.dir property will keep functionality of the keystore as-is (user.dir)

@centrys-victor
Copy link
Author

@qoire Yes. If the local.storage.dir is not set it will fallback to the user.dir

Copy link
Collaborator

@AionJayT AionJayT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AionJayT AionJayT merged commit 4cefbfe into aionnetwork:master-pre-merge Jun 7, 2018
@AionJayT AionJayT mentioned this pull request Jun 14, 2018
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants